Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Withdrawal Credential Update Request #9005

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lucassaldanha
Copy link
Contributor

@lucassaldanha lucassaldanha commented Oct 31, 2024

EIP-7804: Withdrawal Credential Update Request

Allow validators to update their withdrawal credentials via execution requests

This proposal defines a mechanism to allow validators to update their withdrawal
credentials using a new execution request type (0x03). The request allows for
changing the execution address and the withdrawal credential prefix (0x01 or 0x02).

@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Oct 31, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 31, 2024

File EIPS/eip-7804.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 31, 2024
@eth-bot eth-bot changed the title EIP-7800: Withdrawal Credential Update Request Add EIP: Withdrawal Credential Update Request Oct 31, 2024
Copy link

The commit 25b6116 (as a parent of 9a4e52c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 31, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 31, 2024
EIPS/eip-7800.md Outdated Show resolved Hide resolved
EIPS/eip-7800.md Outdated Show resolved Hide resolved
EIPS/eip-7800.md Outdated Show resolved Hide resolved
Copy link

@Deluaney1 Deluaney1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x455a12641342dFfec841af14110BE5b0563E86d3

@lucassaldanha
Copy link
Contributor Author

@abcoathup I have made the suggested changes and everything is green now. Could we proceed to merge this proposal?

@Deluaney1
Copy link

Deluaney1 commented Nov 10, 2024 via email

@abcoathup
Copy link
Contributor

Could we proceed to merge this proposal?

You need an editor to review, which I am not.

@Deluaney1
Copy link

Deluaney1 commented Nov 10, 2024 via email

EIPS/eip-7804.md Outdated Show resolved Hide resolved
EIPS/eip-7804.md Outdated Show resolved Hide resolved
@lucassaldanha
Copy link
Contributor Author

@g11tech thanks for the comments. Could you take a second look? Cheers!


#### Block processing

At the end of processing any execution block where `block.timestamp >= FORK_TIMESTAMP` (i.e. after processing all transactions and after performing the block body requests validations) client software **MUST** include a call the contract as `SYSTEM_ADDRESS` and empty input data to trigger the system subroutine execute. The resopnse should be treated as a new request type (0x03) according to [EIP-7685](./eip-7685.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
At the end of processing any execution block where `block.timestamp >= FORK_TIMESTAMP` (i.e. after processing all transactions and after performing the block body requests validations) client software **MUST** include a call the contract as `SYSTEM_ADDRESS` and empty input data to trigger the system subroutine execute. The resopnse should be treated as a new request type (0x03) according to [EIP-7685](./eip-7685.md).
At the end of processing any execution block where `block.timestamp >= FORK_TIMESTAMP` (i.e. after processing all transactions and after performing the block body requests validations) client software **MUST** include a call the contract as `SYSTEM_ADDRESS` and empty input data to trigger the system subroutine execute. The response should be treated as a new request type (0x03) according to [EIP-7685](./eip-7685.md).

EIPS/eip-7804.md Outdated

### Consensus Layer

Full specification <!-- TODO add link to consensus-spec PR -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the specification here also looks half baked so can you add another <!-- TODO complete the specification --> so we can merge this for draft

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants